From dbcb79f992e2e8788ffa2cac3ea9100695928e27 Mon Sep 17 00:00:00 2001 From: Adrien1106 Date: Wed, 14 May 2025 03:56:03 +0200 Subject: [PATCH] improved: removed unnecessary check + inner cull improvement --- .../java/fr/adrien1106/reframed/client/util/RenderHelper.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/fr/adrien1106/reframed/client/util/RenderHelper.java b/src/main/java/fr/adrien1106/reframed/client/util/RenderHelper.java index 93123a0..b651c85 100644 --- a/src/main/java/fr/adrien1106/reframed/client/util/RenderHelper.java +++ b/src/main/java/fr/adrien1106/reframed/client/util/RenderHelper.java @@ -94,7 +94,7 @@ public class RenderHelper { } catch (NullPointerException e) { // this can happen if mod haven't thought about inner faces return true; } - return !self_theme.isOpaque() || !other_theme.isOpaque(); + return self_theme.isOpaque() != other_theme.isOpaque() && self_theme.isOpaque(); } // Doing this method from scratch as it is simpler to do than injecting everywhere @@ -141,7 +141,7 @@ public class RenderHelper { if (self_theme.isSideInvisible(other_state, side)) return false; // Opaque is also simple as each model are rendered one by one - if (other_state.isOpaque() && self.isSolid()) { + if (other_state.isOpaque()) { // no cache section :( because it differs between each instance of the frame VoxelShape self_shape = self_block.getShape(self_state, theme_index).getFace(side); if (self_shape.isEmpty()) return true;