Altarik/ReFramed
4
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

improved: removed unnecessary check + inner cull improvement

Browse Source
This commit is contained in:
Adrien1106
2025-05-14 03:56:03 +02:00
parent 8d8a0e3654
commit dbcb79f992
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/main/java/fr/adrien1106/reframed/client/util/RenderHelper.java
View File

@@ -94,7 +94,7 @@ public class RenderHelper {
} catch (NullPointerException e) { // this can happen if mod haven't thought about inner faces } catch (NullPointerException e) { // this can happen if mod haven't thought about inner faces
return true; return true;
} }
return !self_theme.isOpaque() || !other_theme.isOpaque(); return self_theme.isOpaque() != other_theme.isOpaque() && self_theme.isOpaque();
} }
// Doing this method from scratch as it is simpler to do than injecting everywhere // Doing this method from scratch as it is simpler to do than injecting everywhere
@@ -141,7 +141,7 @@ public class RenderHelper {
if (self_theme.isSideInvisible(other_state, side)) return false; if (self_theme.isSideInvisible(other_state, side)) return false;
// Opaque is also simple as each model are rendered one by one // Opaque is also simple as each model are rendered one by one
if (other_state.isOpaque() && self.isSolid()) { if (other_state.isOpaque()) {
// no cache section :( because it differs between each instance of the frame // no cache section :( because it differs between each instance of the frame
VoxelShape self_shape = self_block.getShape(self_state, theme_index).getFace(side); VoxelShape self_shape = self_block.getShape(self_state, theme_index).getFace(side);
if (self_shape.isEmpty()) return true; if (self_shape.isEmpty()) return true;